-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build setting for Dockerfile. #4208
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the log https://build.ros.org/job/doc_ros2doc/1233/console, docker build and run failed without devcontainer.
this is because of CMD
with multiple lines, that was the bug so that docker build fails to build the html.
the reason devcontainer
successfully build is, it does not use CMD
, instead postCreateCommand
with locale setup.
docker build --force-rm -f ./docker/image/Dockerfile -t ros2_documentation .
docker run --rm --net=host -v /home/tomoyafujita/DVT/03_OSS/github.com/fujitatomoya/ros2_documentation:/tmp/doc_repository ros2_documentation
i checked the above works without any problems. besides, devcontainer build also succeeds without problem.
@audrow sorry, i need to ask you to see if this work with codespace again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as a codespace!
All right, I'll go ahead and merge this one and give it a shot in https://build.ros.org/job/doc_ros2doc/ right away to check it. If it doesn't work, I'll end up reverting it again :). |
Looks successful: https://build.ros.org/job/doc_ros2doc/1236/console Thanks @fujitatomoya ! |
@Mergifyio backport humble iron |
✅ Backports have been created
|
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit a235f39)
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit a235f39)
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit a235f39) Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit a235f39) Co-authored-by: Tomoya Fujita <[email protected]>
address #4184, replace #4198