Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ros2 service echo beginners CLI and Service Introspection demo. #4199

Merged
merged 3 commits into from
Mar 4, 2024
Merged

add ros2 service echo beginners CLI and Service Introspection demo. #4199

merged 3 commits into from
Mar 4, 2024

Conversation

fujitatomoya
Copy link
Collaborator

to close ros2/ros2#1285 and replace #2981

fujitatomoya
fujitatomoya commented Mar 3, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette @Yadunund can you take a look?

This was referenced Mar 3, 2024
Closed
Closed
Yadunund
Yadunund approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very valuable addition to the tutorials! Thanks a lot Tomoya! Left some minor nitpicks to consider.

@fujitatomoya
review comments update.
3c4664e 
Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@Yadunund thanks for the review!

@fujitatomoya fujitatomoya merged commit a07196c into rolling Mar 4, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/service-introspection-tutorial branch March 4, 2024 17:25
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2024 •
edited
Loading

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 4, 2024
@fujitatomoya @mergify
add ros2 service echo beginners CLI and Service Introspection demo. (…
cc164a4 
…#4199)

* add `ros2 service echo` beginners CLI tutorial.

Signed-off-by: Tomoya.Fujita <[email protected]>

* add Service Introspection tutorial.

Signed-off-by: Tomoya.Fujita <[email protected]>

* review comments update.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit a07196c)
@mergify mergify bot mentioned this pull request Mar 4, 2024
Merged
clalancette pushed a commit that referenced this pull request Mar 4, 2024
@mergify @fujitatomoya
add ros2 service echo beginners CLI and Service Introspection demo. (…
fe6474b 
…#4199) (#4202)

* add `ros2 service echo` beginners CLI tutorial.

Signed-off-by: Tomoya.Fujita <[email protected]>

* add Service Introspection tutorial.

Signed-off-by: Tomoya.Fujita <[email protected]>

* review comments update.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
(cherry picked from commit a07196c)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@audrow audrow Awaiting requested review from audrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Introspection
2 participants
@fujitatomoya @Yadunund