Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Jazzy release note. #4160

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

fujitatomoya
Copy link
Collaborator

doc follow-up for ros2/rclpy#1216

Signed-off-by: Tomoya Fujita <[email protected]>
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette jazzy release note update for ros2/rclpy#1216, can you take a look?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably rearrange this page a bit. In particular, if you look at e.g. http://docs.ros.org/en/rolling/Releases/Release-Iron-Irwini.html , you'll see that there is a "New features in this ROS 2 release", as well as a "Changes since the Humble release" section. I think we should do the same here, and sort the existing items properly. Then we can add in the new item into "Changes since the Iron release" section.

@fujitatomoya does that make sense? Would you be willing to do that?

@fujitatomoya
Copy link
Collaborator Author

@clalancette sure thing, i will do that.

@fujitatomoya
Copy link
Collaborator Author

I think we should probably rearrange this page a bit. In particular, if you look at e.g. http://docs.ros.org/en/rolling/Releases/Release-Iron-Irwini.html , you'll see that there is a "New features in this ROS 2 release", as well as a "Changes since the Humble release" section. I think we should do the same here, and sort the existing items properly. Then we can add in the new item into "Changes since the Iron release" section.

@fujitatomoya does that make sense? Would you be willing to do that?

@clalancette just pushed the change, can you check?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, thanks for revamping it like this.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 12, 2024
@clalancette clalancette merged commit 988e748 into rolling Feb 12, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/ros2-param-dump-print-bug branch February 12, 2024 23:50
mergify bot pushed a commit that referenced this pull request Feb 12, 2024
* update Jazzy release note.

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 988e748)
mergify bot pushed a commit that referenced this pull request Feb 12, 2024
* update Jazzy release note.

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 988e748)
tfoote pushed a commit that referenced this pull request Feb 13, 2024
* update Jazzy release note.

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 988e748)

Co-authored-by: Tomoya Fujita <[email protected]>
tfoote pushed a commit that referenced this pull request Feb 13, 2024
* update Jazzy release note.

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 988e748)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants