Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc for "--log-file-name" command line argument. #4087

Merged
merged 4 commits into from
Jan 10, 2024
Merged

add doc for "--log-file-name" command line argument. #4087

merged 4 commits into from
Jan 10, 2024

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya mentioned this pull request Jan 4, 2024
Closed
kscottz
kscottz reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion for how to phrase what I think you were saying. If that looks correct please add it and I think we should be good to go.

source/How-To-Guides/Node-arguments.rst Outdated Show resolved Hide resolved
source/Tutorials/Demos/Logging-and-logger-configuration.rst Outdated Show resolved Hide resolved
source/Tutorials/Demos/Logging-and-logger-configuration.rst Outdated Show resolved Hide resolved
@fujitatomoya @kscottz
address review comments.
4d4de2c 
Signed-off-by: Tomoya.Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@kscottz thanks for the review comments, i borrowed your suggested fixes 👍 (added you as Co-Author)

clalancette
clalancette requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording changes. Also, while are adding this here, could you please add a note to the Jazzy release notes page?

source/Tutorials/Demos/Logging-and-logger-configuration.rst Outdated Show resolved Hide resolved
@fujitatomoya
address review comment.
2ab7ac7 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@clalancette thanks for the review, addressed your fix.

@fujitatomoya
update Jazzy release note.
e87629c 
Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

@clalancette

Also, while are adding this here, could you please add a note to the Jazzy release notes page?

missed it, now jazzy release note is updated. can you take a look?

clalancette
clalancette approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm also going to mark this to be backported to Humble and Iron, but just for the Jazzy release note. I'll remove the other bits before merging.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jan 10, 2024
@clalancette clalancette merged commit d412eee into ros2:rolling Jan 10, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@fujitatomoya @mergify
add doc for "--log-file-name" command line argument. (#4087)
e0d7054 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)
mergify bot pushed a commit that referenced this pull request Jan 10, 2024
@fujitatomoya @mergify
add doc for "--log-file-name" command line argument. (#4087)
104e94b 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)
This was referenced Jan 10, 2024
Merged
Merged
clalancette pushed a commit that referenced this pull request Jan 10, 2024
@fujitatomoya @clalancette
add doc for "--log-file-name" command line argument. (#4087)
152f414 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)
clalancette pushed a commit that referenced this pull request Jan 10, 2024
@fujitatomoya @clalancette
add doc for "--log-file-name" command line argument. (#4087)
dc518cb 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)
clalancette pushed a commit that referenced this pull request Jan 10, 2024
@mergify @fujitatomoya
add doc for "--log-file-name" command line argument. (#4087) (#4101)
3638288 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)

Co-authored-by: Tomoya Fujita <[email protected]>
clalancette pushed a commit that referenced this pull request Jan 10, 2024
@mergify @fujitatomoya
add doc for "--log-file-name" command line argument. (#4087) (#4100)
476e9d2 
* add doc for "--log-file-name" command line argument.

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Katherine Scott <[email protected]>
(cherry picked from commit d412eee)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kscottz kscottz kscottz left review comments

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log file is exclusively named after process name in both rclpy and rclcpp
3 participants
@fujitatomoya @clalancette @kscottz