Skip to content

Commit

Permalink
Add recommendation on example source PR (#4253)
Browse files Browse the repository at this point in the history
* Add recommendation on example source PR

* Other ROS devs could use an example directly in the docs for what is a
  source PR
* Fix incorrect grammar

Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 9fe4c95)
  • Loading branch information
Ryanf55 authored and mergify[bot] committed Apr 3, 2024
1 parent bd8e984 commit ac0ab64
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions source/How-To-Guides/Releasing/Release-Team-Repository.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ if a release team already exists for your project but you are not part of it.
Start a new release team
^^^^^^^^^^^^^^^^^^^^^^^^

Fill the `New Release Team issue <https://github.com/ros2-gbp/ros2-gbp-github-org/issues/new?assignees=&labels=&template=new_release_team.md&title=Add+release+team>`_ issue template
if no release team exists for your project yet, request for a new release team to be created.
If no release team exists for your project yet, fill out the `New Release Team issue <https://github.com/ros2-gbp/ros2-gbp-github-org/issues/new?assignees=&labels=&template=new_release_team.md&title=Add+release+team>`_ issue template to request one be created.

.. _what-is-a-release-repository:

Expand All @@ -61,7 +60,7 @@ Having a release repository separate from your source code repository is a requi
Create a new release repository
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

If your repository is new to the ROS community, you should first open a pull request on `ros/rosdistro <https://github.com/ros/rosdistro>`_ adding a ``source`` entry for your repository.
If your repository is new to the ROS community, you should first open a pull request on `ros/rosdistro <https://github.com/ros/rosdistro>`_ adding a ``source`` entry for your repository (e.g. https://github.com/ros/rosdistro/pull/39513).
The review process for the rosdistro database will ensure your repository and packages conform to the `REP 144 package naming conventions <https://www.ros.org/reps/rep-0144.html>`_ and other requirements before release.
Once your package name has been approved and merged, fill in the `Add New Release Repositories issue <https://github.com/ros2-gbp/ros2-gbp-github-org/issues/new?assignees=&labels=&template=new_release_repository.md&title=Add+new+release+repositories>`_ issue template
if you don't have a release repo for your project yet.
Expand Down

0 comments on commit ac0ab64

Please sign in to comment.