Dynamic Subscription (BONUS: Allocators): rmw_fastrtps #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
28 tasks
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
2ec70eb to
37ba2d3
Compare
wjwwood
approved these changes
Apr 10, 2023
emersonknapp
approved these changes
Apr 10, 2023
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
clalancette
requested changes
Apr 10, 2023
Comment on lines
+93
to
+94
| rosidl_dynamic_typesupport_serialization_support_init( | ||
| &impl, &methods, allocator, serialization_support)); |
There was a problem hiding this comment.
This is pre-existing, but I'll point out that this looks like a bug; if rosidl_dynamic_typesupport_serialization_support_init fails, then we'll leak &impl and &methods, no?
There was a problem hiding this comment.
Yeah, will defer to after the merge
delete-merged-branch
bot
deleted the
runtime_interface_reflection_allocators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ros2/ros2#1405