More linters

Signed-off-by: Miguel Company <[email protected]>
ros2 · Oct 29, 2024 · e92f7ed · e92f7ed
1 parent ed7f9d6
commit e92f7ed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/rmw_fastrtps_dynamic_cpp/src/TypeSupport_impl.hpp b/rmw_fastrtps_dynamic_cpp/src/TypeSupport_impl.hpp
@@ -905,7 +905,7 @@ template<typename MembersType>
 size_t TypeSupport<MembersType>::calculateMaxSerializedSize(
   const MembersType * members, size_t current_alignment)
 {
-  bool is_key_unbounded{false}; //unused
+  bool is_key_unbounded{false};  // unused
   return calculateMaxSerializedSize(members, current_alignment, false, is_key_unbounded);
 }
 
@@ -1117,7 +1117,6 @@ bool TypeSupport<MembersType>::get_key_hash_from_ros_message(
   void * ros_message, eprosima::fastrtps::rtps::InstanceHandle_t * ihandle, bool force_md5,
   const void * impl) const
 {
-
   assert(ros_message);
   assert(members_);
 

diff --git a/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/TypeSupport.hpp b/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/TypeSupport.hpp
@@ -17,6 +17,7 @@
 
 #include <cassert>
 #include <string>
+#include <vector>
 
 #include "fastdds/dds/topic/TopicDataType.hpp"
 

diff --git a/rmw_fastrtps_shared_cpp/src/TypeSupport_impl.cpp b/rmw_fastrtps_shared_cpp/src/TypeSupport_impl.cpp
@@ -90,14 +90,13 @@ bool TypeSupport::getKey(
 
     case FASTRTPS_SERIALIZED_DATA_TYPE_CDR_BUFFER:
       {
-        // TODO
-        // We would need a get_key_hash_from_payload method
+        // TODO(MiguelCompany): In order to support keys in rmw_publish_serialized_message,
+        // we would need a get_key_hash_from_payload method
         break;
       }
 
     case FASTRTPS_SERIALIZED_DATA_TYPE_DYNAMIC_MESSAGE:
       {
-
         auto m_type = std::make_shared<eprosima::fastrtps::types::DynamicPubSubType>();
 
         // Retrieves the key (ihandle) from the dynamic data stored in data->data