Skip to content

Commit

Permalink
to support reset content filtered topic with empty string.
Browse files Browse the repository at this point in the history
remove constness for rmw_subscription because is_cft_supported might be updated

Signed-off-by: Chen Lihui <[email protected]>
  • Loading branch information
Chen Lihui committed Mar 12, 2021
1 parent 1925704 commit cb43991
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rmw_fastrtps_cpp/src/rmw_subscription.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ rmw_subscription_get_actual_qos(

rmw_ret_t
rmw_subscription_set_cft_expression_parameters(
const rmw_subscription_t * subscription,
rmw_subscription_t * subscription,
const char * filter_expression,
const rcutils_string_array_t * expression_parameters)
{
Expand Down
1 change: 1 addition & 0 deletions rmw_fastrtps_cpp/src/subscription.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ create_subscription(
}
rmw_subscription->options = *subscription_options;
rmw_subscription->can_loan_messages = false;
rmw_subscription->is_cft_supported = false;

cleanup_rmw_subscription.cancel();
cleanup_subscription.cancel();
Expand Down
2 changes: 1 addition & 1 deletion rmw_fastrtps_dynamic_cpp/src/rmw_subscription.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ rmw_subscription_get_actual_qos(

rmw_ret_t
rmw_subscription_set_cft_expression_parameters(
const rmw_subscription_t * subscription,
rmw_subscription_t * subscription,
const char * filter_expression,
const rcutils_string_array_t * expression_parameters)
{
Expand Down
1 change: 1 addition & 0 deletions rmw_fastrtps_dynamic_cpp/src/subscription.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ create_subscription(

rmw_subscription->options = *subscription_options;
rmw_subscription->can_loan_messages = false;
rmw_subscription->is_cft_supported = false;

cleanup_rmw_subscription.cancel();
cleanup_subscription.cancel();
Expand Down

0 comments on commit cb43991

Please sign in to comment.