Skip to content

Document which QoS policies are correctly read by rmw_get_publishers/subscriptions_info_by_topic #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Document which QoS policies are correctly read by rmw_get_publishers/subscriptions_info_by_topic #308

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5957ea0
Document which QoS policies are correctly read by rmw_get_publishers/…
ivanpauno Apr 12, 2021
6790f5b
style
ivanpauno Apr 12, 2021
aa3a366
style
ivanpauno Apr 12, 2021
dbc1d28
Remove unnecessary indentation
ivanpauno Apr 12, 2021
56983bb
Address peer review comment
ivanpauno Apr 12, 2021
10b6c6b
Be more clear about what is specific of DDS
ivanpauno Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rmw/include/rmw/get_topic_endpoint_info.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ extern "C"
* the associated topic type, the publisher's gid, and the publisher QoS profile.
* Names of non-existent topics are allowed, in which case an empty array will be returned.
*
* \par QoS that are correctly read
* The QoS profiles returned might have some invalid fields.
* The rmw implementation must set the invalid fields to `RMW_QOS_POLICY_*_UNKNOWN`.
* For DDS based implementations, the only QoS policies that are guaranteed to be shared
* during discovery are the ones that participate in endpoint matching.
* From the current QoS settings available, the only ones not shared by DDS based
* implementations are `history` and `history_depth`.
*
* <hr>
* Attribute | Adherence
* ------------------ | -------------
Expand Down Expand Up @@ -105,6 +113,9 @@ rmw_get_publishers_info_by_topic(
* the associated topic type, the subscription's gid, and the subscription QoS profile.
* Names of non-existent topics are allowed, in which case an empty array will be returned.
*
* \par QoS that are correctly read
* Not all QoS may be read correctly, \sa rmw_get_publishers_info_by_topic() for more details.
*
* <hr>
* Attribute | Adherence
* ------------------ | -------------
Expand Down