Skip to content

Improve the robustness of the TopicEndpointInfo constructor #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmachowinski merged 2 commits into from
Jan 10, 2026
Merged

Improve the robustness of the TopicEndpointInfo constructor #3013

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bea1f
Improve the robustness of the TopicEndpointInfo constructor
Barry-Xu-2018 Jan 7, 2026
fafb5cc
Improve TopicEndpointInfo constructor to validate input parameters
Barry-Xu-2018 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rclcpp/include/rclcpp/node_interfaces/node_graph_interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ class TopicEndpointInfo
/// Construct a TopicEndpointInfo from a rcl_topic_endpoint_info_t.
RCLCPP_PUBLIC
explicit TopicEndpointInfo(const rcl_topic_endpoint_info_t & info)
: node_name_(info.node_name),
node_namespace_(info.node_namespace),
topic_type_(info.topic_type),
: node_name_(info.node_name ? info.node_name : ""),
node_namespace_(info.node_namespace ? info.node_namespace : ""),
topic_type_(info.topic_type ? info.topic_type : ""),
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null pointer checks added to protect against nullptr values for node_name, node_namespace, and topic_type should be covered by tests. Consider adding a test case that creates a TopicEndpointInfo with an rcl_topic_endpoint_info_t structure containing nullptr values for these fields to verify the fix handles this edge case correctly.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@Barry-Xu-2018 Barry-Xu-2018 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, TopicEndpointInfo has not been tested in any of the test code. Besides, this modification is simple. Is it necessary to add a new test file to test such a simple change?

endpoint_type_(static_cast<rclcpp::EndpointType>(info.endpoint_type)),
qos_profile_({info.qos_profile.history, info.qos_profile.depth}, info.qos_profile),
topic_type_hash_(info.topic_type_hash)
Expand Down