Skip to content

Conversation

@fujitatomoya
Copy link
Collaborator

This reverts commit c80701e.

Description

This reverts #1248, which generates the following CI warnings.

https://ci.ros2.org/job/ci_linux-aarch64/19464/

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

see discussion ros2/rclcpp#2910, on the rclcpp layer, this will generate the inconsistent behavior between now and sleep_until methods. until it can be resolved, i think we do not need to merge this rcl layer either.

@fujitatomoya fujitatomoya requested a review from ahcorde October 9, 2025 02:19
@fujitatomoya fujitatomoya self-assigned this Oct 9, 2025
@fujitatomoya
Copy link
Collaborator Author

@ahcorde i think we need to revert this, can you review the description and approve?

@fujitatomoya
Copy link
Collaborator Author

Pulls: #1267
Gist: https://gist.githubusercontent.com/fujitatomoya/ce7fef884ca20e160b242effde1c7f4f/raw/646bc8be8e82b0518f72c4be43401928db94af60/ros2.repos
BUILD args: --packages-above-and-dependencies rcl
TEST args: --packages-above rcl
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17260

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Note

after this revert commit is merged, we need to create revert this reverted commit and link it to the client's PRs.

/// Use a steady clock time
RCL_STEADY_TIME,
/// Use a monotonic slew-free steady clock time
RCL_RAW_STEADY_TIME
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is not checked in the client rclcpp/rclpy layer just yet, that generates the CI warnings.

@ahcorde ahcorde merged commit 7f997d3 into rolling Oct 9, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/pull/revert-1248 branch October 9, 2025 08:46
@SuperJappie08
Copy link

@ahcorde & @fujitatomoya, I think some tests are still using the reverted API change.

@fujitatomoya
Copy link
Collaborator Author

@SuperJappie08 can you point out where it is in the source code link?

@SuperJappie08
Copy link

@fujitatomoya, sorry I looked wrong.
I first tried building without a git-rolling version of rcutiils, and it missed a function, but it was unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants