-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use user-defined allocator to configure logging. #1047
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on rcl
layer, there are two exported functions to set allocator
for rcutils
log module.
- rcl_logging_configure -> rcl_logging_configure_with_output_handler
- rcl_logging_configure_with_output_handler
If a component(such as rclcpp
) doesn't call the above functions, logging functions on rcutils
layer use the default allocator
by the RCUTILS_LOGGING_AUTOINIT
.
I think it makes sense.
and we need to remove Lines 71 to 74 in cae279a
|
this one has been already pointed out by #1037, i believe that each PR should be against specific issue. So i will not address it here. |
https://ci.ros2.org/job/ci_windows/18945/#showFailuresLink unstable failure is not related to this PR. |
Signed-off-by: Tomoya Fujita <[email protected]>
address #1036