Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts in Mergify/bp/humble/pr 353 #390

Conversation

Ryanf55
Copy link

@Ryanf55 Ryanf55 commented Jan 17, 2024

This fixes conflicts for the backport to humble of #353.

Manual colcon test report ✔️

root@AutonomyML01:/ws# colcon test --packages-select launch_testing_ros --event-handlers=console_cohesion+
Starting >>> launch_testing_ros
--- output: launch_testing_ros                     
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-6.2.5, py-1.10.0, pluggy-0.13.0
cachedir: /ws/build/launch_testing_ros/.pytest_cache
rootdir: /ws/launch_testing_ros, configfile: pytest.ini, testpaths: test
plugins: launch-testing-ros-0.19.6, ament-pep257-0.12.7, ament-copyright-0.12.7, ament-flake8-0.12.7, ament-lint-0.12.7, ament-xmllint-0.12.7, launch-testing-1.0.4, colcon-core-0.12.1
collecting ... 
collected 8 items                                                              

test/test_copyright.py .                                                 [ 12%]
test/test_flake8.py .                                                    [ 25%]
test/test_pep257.py .                                                    [ 37%]
test/examples/check_msgs_launch_test.py .                                [ 50%]
test/examples/check_node_launch_test.py .                                [ 62%]
test/examples/set_param_launch_test.py .                                 [ 75%]
test/examples/talker_listener_launch_test.py .                           [ 87%]
test/examples/wait_for_topic_launch_test.py .                            [100%]

=============================== warnings summary ===============================
test/test_flake8.py::test_flake8
test/test_flake8.py::test_flake8
  Warning: SelectableGroups dict interface is deprecated. Use select.

-- Docs: https://docs.pytest.org/en/stable/warnings.html
--------- generated xml file: /ws/build/launch_testing_ros/pytest.xml ----------
======================== 8 passed, 2 warnings in 18.83s ========================
---
--- stderr: launch_testing_ros

=============================== warnings summary ===============================
test/test_flake8.py::test_flake8
test/test_flake8.py::test_flake8
  Warning: SelectableGroups dict interface is deprecated. Use select.

-- Docs: https://docs.pytest.org/en/stable/warnings.html
---
Finished <<< launch_testing_ros [19.4s]

Summary: 1 package finished [19.5s]
  1 package had stderr output: launch_testing_ros

Signed-off-by: Ryan Friedman <[email protected]>
@adityapande-1995 adityapande-1995 merged commit cadfbab into ros2:mergify/bp/humble/pr-353 Jan 17, 2024
2 checks passed
adityapande-1995 pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
mjcarroll pushed a commit that referenced this pull request Jan 20, 2024
… (#389)

* `WaitForTopics`: get content of messages for each topic (#353)

* Get content of topic from launch_testing_ros::WaitForTopics
#346
Signed-off-by: Pintaudi Giorgio <[email protected]>
---------

Signed-off-by: Pintaudi Giorgio <[email protected]>
(cherry picked from commit 2d125a5)

# Conflicts:
#	launch_testing_ros/launch_testing_ros/wait_for_topics.py
#	launch_testing_ros/test/examples/wait_for_topic_launch_test.py
Signed-off-by: Aditya Pande <[email protected]>

* Resolve conflicts (#390)

Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>

---------

Signed-off-by: Pintaudi Giorgio <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Co-authored-by: Giorgio Pintaudi <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants