Fixed deadlock in destructor in TransformListener #752
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
reviewed
Jan 23, 2025
| @@ -71,6 +71,7 @@ TransformListener::TransformListener(tf2::BufferCore & buffer, bool spin_thread, | |||
| TransformListener::~TransformListener() | |||
| { | |||
| if (spin_thread_) { | |||
| running_.store(false); | |||
There was a problem hiding this comment.
I find it very surprising that this pattern is needed, as it is (essentially) the same as what executor_->cancel() should be doing under the hood. I'm going to see if I can reproduce against jammy/rolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated patch of merge request #518
Related issue: #517
This is issue is still affecting Humble and causes, for example, timeouts in unit tests. The linked merge request provides an example of how to reproduce this issue.