Skip to content

Compatibility with 1.75 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Jul 17, 2025

Some recent updates to this repo have led to CI failing in rclrs for the minimal Rust version 1.75.

This PR aims to fix it via the following:

  • Use a compatible resolver for the workspace Cargo.toml (2 instead of 3)
  • Add a CI workflow that verifies this repo is working for both 1.75 and the latest stable
  • Remove the Cargo.lock files so they don't create confusion for older versions of Rust

@mxgrey
Copy link
Contributor Author

mxgrey commented Jul 17, 2025

Apparently we were never running the tests for this package with the serde feature enabled, because we had some invalid test cases which are now fixed in this PR.

Copy link
Contributor

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, though I'd feel more comfortable if a second maintainer could have a look since I'm not the most experienced with workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants