-
Notifications
You must be signed in to change notification settings - Fork 4
Compatibility with 1.75 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Apparently we were never running the tests for this package with the |
Signed-off-by: Michael X. Grey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, though I'd feel more comfortable if a second maintainer could have a look since I'm not the most experienced with workflows
Some recent updates to this repo have led to CI failing in rclrs for the minimal Rust version 1.75.
This PR aims to fix it via the following:
Cargo.toml
(2 instead of 3)Cargo.lock
files so they don't create confusion for older versions of Rust