Skip to content

Add Ray Message #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Ray Message #125

wants to merge 1 commit into from

Conversation

Jmeyer1292
Copy link

My use case is publishing user mouse clicks in Rviz to external ROS nodes. Didn't find a standard message for a ray, so I here I am.

@tfoote
Copy link
Member

tfoote commented May 9, 2018

This looks like a reasonable message definition. Can you point to places using this or a similar message for example use cases to show that in it's current form it will be useful. Are there equivalent datatypes in use in other geometry libraries? And do you have converter and transform operations that could be added to tf2_geometry_msgs to support it?

@@ -0,0 +1,3 @@
# A representation of a ray in 3-space, composed of an origin and a direction
Point origin
Vector3 direction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vector3 direction
Quaternion direction

A direction cannot have magnitude, but a Vector3 does.

@sloretz
Copy link
Contributor

sloretz commented Apr 25, 2025

Thank you for the PR!

Unfortunately I don't think we should merge this one.

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. I'm closing pull requests that add features so that the remaining time is allocated towards bug fixes and compatibility with newer Ubuntu distros.

@sloretz sloretz closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants