Fix diagnostics #10
Fix diagnostics #10
Conversation
|
Ignore Travis CI, it's not really supported. I'm working on that too... see #9 |
|
LGTM 👍 |
|
|
||
| stat.add("loop time in [sec]", status_.main_loop_time); | ||
| stat.add("data age in [sec]", status_.reading_age); | ||
| stat.add("current lock priority", static_cast<int>(status_.priority)); |
There was a problem hiding this comment.
now only current lock priority is displayed (however, this works)
why is the Key-Value pair for current priority removed? Is this information not retrievable? (this would be the information I'm looking for)
current lock priority is still 0 in case one of the topics is unmasked
There was a problem hiding this comment.
@ipa-fxm current lock priority replaces current priority.
The others are simply not used anywhere.
The current lock priority is related with the locks, not the topics. But I honestly didn't have time to look if I can make the diagnostics more clear.
Do you mind if I merge this and then we discuss how to improve it on an issue?
I'd like to have this merged for ROS kinetic release.
|
Merging... @ipa-fxm Please create an issue if you still consider there's something missed after this. My intention is to release a new version for jade and kinetic with this. Do you need this on indigo too? |
This basically remove old/deprecated variables and diagnostics from an old non-asynchronous implementation.
Note that the last commit is sort of WIP, or could be addressed later.
This addresses #5
@ipa-fxm @bmagyar