-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate c headers #206
base: ros2
Are you sure you want to change the base?
Deprecate c headers #206
Conversation
@CursedRock17 looks like tests are failing |
I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues. |
With the recent backports merged, this PR should be good for review. |
Hi @jonbinney, when you merge this PR, do you mind to create a new release on rolling ? |
Will do - i'll take a look this weekend. |
Looks like tests are still failing.... when did the |
It looks like the changes to the tf2 package got released, but aren't yet in the docker containers used by the CI. |
Yeah, even in the rolling container only tf2 version
We could update CI to |
Related to this pull request in
geometry2
in which we deprecated the.h
style headers in favor of.hpp
.