Skip to content

Default index link no homepage #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: refactor
Choose a base branch
from
Open

Default index link no homepage #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5465b53
Set index.ros.org as the default homepage link unless otherwise set.
tfoote Oct 14, 2025
4892518
add rosdistro to the link and fix canonicalization
tfoote Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/reprepro_updater/diff_repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ def get_packagefile_from_url(url):
return package_file


def conditional_markdown_package_homepage_link(package, package_file):
def conditional_markdown_package_homepage_link(package, package_file, rosdistro=None):
if 'Homepage' in package_file[package]:
return "[%s](%s)" % (package, package_file[package]['Homepage'])
else:
return package
return "[%s](https://index.ros.org/p/%s/#%s)" % (package, package, rosdistro)
Copy link
Member

@christophebedard christophebedard Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is package here $pkg_name or ros-$distro-$pkg_name?

Based on a typical output we use (example from a recent Jazzy sync announcement), this should be ros-$distro-${pkg-name}.

Copy link
Member Author

@tfoote tfoote Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, you're right.

I was making ros-infrastructure/bloom#754 as a complement to get the info into more places, but maybe that would just be a better replacement going further upstream.



def compute_annoucement(rosdistro, pf_old, pf_new):
Expand Down Expand Up @@ -117,21 +117,21 @@ def compute_annoucement(rosdistro, pf_old, pf_new):
out += "### Added Packages [%s]:\n\n" % len(added_packages)
for p in sorted(added_packages):
out += " * %s: %s\n" % \
(conditional_markdown_package_homepage_link(p, new_packages),
(conditional_markdown_package_homepage_link(p, new_packages, rosdistro),
core_version(new_packages[p]['Version']))
out += "\n"

out += "### Updated Packages [%s]:\n\n" % len(updated_packages)
for p in sorted(updated_packages):
out += " * %s: %s -> %s\n" % \
(conditional_markdown_package_homepage_link(p, new_packages),
(conditional_markdown_package_homepage_link(p, new_packages, rosdistro),
core_version(old_packages[p]['Version']),
core_version(new_packages[p]['Version']))
out += "\n"

out += "### Removed Packages [%s]:\n\n" % len(removed_packages)
for p in sorted(removed_packages):
out += "- %s\n" % (conditional_markdown_package_homepage_link(p, old_packages),)
out += "- %s\n" % (conditional_markdown_package_homepage_link(p, old_packages, rosdistro),)
out += "\n"

out += \
Expand Down