Updated definition of raster planner base class#364
Merged
marip8 merged 2 commits intoros-industrial:masterfrom Jan 7, 2026
Merged
Updated definition of raster planner base class#364marip8 merged 2 commits intoros-industrial:masterfrom
marip8 merged 2 commits intoros-industrial:masterfrom
Conversation
…definition into plane slicer raster planner
201fcef to
0c1235f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
RasterPlannerclass hooks for setting the point spacing and minimum hole size, but it turns out that those tasks are not really raster planner specific and can (and should) be done using separate tool path modifiers. This will allow us to reduce the amount of code in the raster planners themselves since these tasks can be defined once as tool path modifiers, and it gives end users more control over the resulting tool paths because they can choose how/if these tasks are performed.This PR moves the point spacing and min hole size parameters from the raster planner base class into the plane slicer raster planner class. The revision to the plane slicer raster planner in #350 will then remove these parameters (and a few others) from the plane slicer raster planner in favor of using existing mesh modifiers and tool path modifiers to perform those tasks.