Skip to content

Updated definition of raster planner base class#364

Merged
marip8 merged 2 commits intoros-industrial:masterfrom
marip8:update/raster-planner-def
Jan 7, 2026
Merged

Updated definition of raster planner base class#364
marip8 merged 2 commits intoros-industrial:masterfrom
marip8:update/raster-planner-def

Conversation

@marip8
Copy link
Member

@marip8 marip8 commented Jan 7, 2026

The current RasterPlanner class hooks for setting the point spacing and minimum hole size, but it turns out that those tasks are not really raster planner specific and can (and should) be done using separate tool path modifiers. This will allow us to reduce the amount of code in the raster planners themselves since these tasks can be defined once as tool path modifiers, and it gives end users more control over the resulting tool paths because they can choose how/if these tasks are performed.

This PR moves the point spacing and min hole size parameters from the raster planner base class into the plane slicer raster planner class. The revision to the plane slicer raster planner in #350 will then remove these parameters (and a few others) from the plane slicer raster planner in favor of using existing mesh modifiers and tool path modifiers to perform those tasks.

@marip8 marip8 force-pushed the update/raster-planner-def branch from 201fcef to 0c1235f Compare January 7, 2026 17:39
@marip8 marip8 merged commit 095ea40 into ros-industrial:master Jan 7, 2026
9 of 10 checks passed
@marip8 marip8 deleted the update/raster-planner-def branch January 7, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant