Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for Galactic and Rolling #188

Closed
henningkayser opened this issue May 25, 2021 · 5 comments
Closed

Release for Galactic and Rolling #188

henningkayser opened this issue May 25, 2021 · 5 comments

Comments

@henningkayser
Copy link

What's the status on releasing ros2_controllers for Galactic or Rolling?
We are planning to release MoveIt for both distros end of June and it would be great if this dependency would be available by then.
@henningkayser henningkayser mentioned this issue May 25, 2021
Closed
8 tasks
@Timple
Copy link
Contributor

Timple commented Jun 8, 2021

Did you test this from source already with MoveIt?

I ran into some issues and I'm wondering if you encountered similar ones: #199

@vatanaksoytezer
Copy link
Contributor

vatanaksoytezer commented Jun 14, 2021 •
edited
Loading

@Timple sorry, just saw your message. We've been using ros2_controllers in Rolling and Galactic. We've also set up a new CI for moveit2 build that tests Galactic and Rolling that also builds ros2_control and ros2_controllers from source. See moveit/moveit2#494. ros-controls people helped us merge a couple of PRs to enable Rolling and Galactic source builds already. If you can share what issues you are facing, I would be glad to help.

@Timple
Copy link
Contributor

Timple commented Jun 15, 2021

The issues I'm facing are with the diff_drive_controller. Probably not in use for moveit 🙂
But I already solved them in #199

@lukicdarkoo lukicdarkoo mentioned this issue Jul 19, 2021
Closed
@joe28965
Copy link

Is it me or has ros2_controllers since been released on both Galactic and Rolling and should this issue be closed?

@bmagyar
Copy link
Member

bmagyar commented Apr 12, 2022

Oh yes of course, long since it's been released to both. Closing

@bmagyar bmagyar closed this as completed Apr 12, 2022
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this issue Jun 7, 2023
@guru-florida
Feature/191 joint limits without sharedptr (ros-controls#194)
f9d4e61 
* ros-controls#188 refactored enforceLimits to enforce_limits

* ros-controls#191 removed std::shared_ptr from Joint Limits handles

* ros-controls#191 cleaner default custruction of Joint Handles with DEFAULT_POSITION|VELOCITY|COMMAND_HANDLE macros

* ros-controls#191 added operator-bool to Handle<> template class for testing if handle has a reference set. uncrustify fixes on joint limits macros

* added Handle<> constructors initializing interface_name only, and setter for interface_name,value

* updated joint limit handles to use new Handle constructors

* uncrustify and cpplint fixes

* renamed base class JointSaturationLimitHandle to just JointLimitHandle since it is the common base class for Saturation and SoftLimit derived limit classes

* fixed some constructor calls that required explicit JointHandle cast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bmagyar @henningkayser @Timple @vatanaksoytezer @joe28965