[Python] Avoid side effects in libROOTPythonizations initialization #21189
Open
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Open
[Python] Avoid side effects in libROOTPythonizations initialization #21189guitargeek wants to merge 2 commits intoroot-project:masterfrom
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Conversation
It's better if the initalization function doesn't get too different from the default, so that there are no unexpected initialization and garbage collection effects. In fact, the extra reference directly contradicted a comment a few lines further up: > keep gRootModule, but do not increase its reference count
There are some side effects when importing the ROOT CPython extension that we should better avoid, so that all active initialization is centralized in `ROOTFacade._finalSetup()`. Like this, it will be easier for us and our users to keep track of what the differences between the base cppyy and the ROOT C++ runtime are. That should help explaining to our users that they usually don't need to import cppyy directly,
Test Results 22 files 22 suites 3d 11h 13m 17s ⏱️ Results for commit 3e33c35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some side effects when importing the ROOT CPython extension
that we should better avoid, so that all active initialization is
centralized in
ROOTFacade._finalSetup().Like this, it will be easier for us and our users to keep track of what
the differences between the base cppyy and the ROOT C++ runtime are.
That should help explaining to our users that they usually don't need to
import cppyy directly,
In particular, the extra reference directly contradicted a comment a few lines
further up: