Increase number of tests in stressGraphics #20216
Open
+31,146
−366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrows - still need to fix TArrow save primitive
One can easily recognize them and prevent problems when changing test number
Make it as separate commit to simplify git a work. Now only single line in each svg file will be replaced.
Test Results 21 files 21 suites 3d 12h 2m 16s ⏱️ For more details on these failures, see this check. Results for commit 3a16bb8. ♻️ This comment has been updated with latest results. |
linev
force-pushed
the
more_stress
branch
2 times, most recently
from
7a66a82 to
968fc20
Compare
There are some bug in ROOT graphics handling such canvas, web graphics works as expected!!!
Saving in macro does not work at all SVG output varies on several platforms - to be investigated later
couet
approved these changes
Oct 29, 2025
Store in macro does not work and need to be fixed extra
THStack store in macro is not working
To be sure that such modifications reliably works
When many new test were add, test ids check was disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many classes and many special draw options were not tested.
So adding new 17 tests to
stressGraphics:TArrowTPolyLineTCrownTPieTGraphMultiErrorTAnnotationin 3D modeTGraphPolarTGraphpad->SetTickx(2),pad->SetTicky(2)to draw axes labels on both sides of the frameTCutGand drawingTH2with cut conditionTPaletteAxisand custom entries for stats boxTH2These new tests also showing problems with saving primitives:
THStack::SavePrimitive()is not workingTGraphPolaralso not workingTArrowdoes not store correctly option stringSeems to be, there is
TGraphpainting problem with "rx" and "ry" option.New introduced test
tgraphreverse()shows problem with producing of PS and SVG files.At the same time web graphics works as expected. Saving of such canvas also not work properly.
So it will be extra work to fix such problems afterwards.
SVG ref files now stored with explicit names instead of
svg<TestNum>.svgnames to avoid big repository changes every time new test is inserted.After merging this PR one can remove completely
roottest/graphics/.Beside several
TMathfunction all ROOT drawing from these graphics tests moved tostressGraphics.stressGraphicsfrom now will be the central testing utility - including precise SVG content tests, working on all platforms.