Explicitly define mutable strings #620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.3 introduced a magic comment, `frozen_string_literal: true`, that allows strings to be immutable by default. Ruby 3.4 is preparing to make this the default behavior and throws deprecation warnings when mutating strings. There are many ways to make a mutable string, but I've chosen to use `String.new` because it is the most explicit option and also doesn't require creating multiple string objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
String.newto explicitly define strings that will be mutableOther Information
Ruby 2.3 introduced a magic comment,
frozen_string_literal: true, that allows strings to be immutable by default. Ruby 3.4 is preparing to make this the default behavior and throws deprecation warnings when mutating strings.There are many ways to make a mutable string, but I've chosen to use
String.newbecause it is the most explicit option and also doesn't require creating multiple string objectsDeprecation warnings are still being thrown by rubyzip. While they have a fix in main, there is no new release and I didn't think it would be appropriate for me to move the dependency to GitHub