Updated to work under Node.js v12 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vlasky, I want to rather move away from NAN entirely in favor of N-API. |
|
I'm on the waitlist 🖐 because of this version incompatible with node@12. |
Can we merge this fix then move away from NAN in a separate PR? |
jakubwolny
reviewed
Sep 21, 2020
Updated nan version to 2.14.1
jchook
reviewed
Nov 16, 2020
|
There hasn't been any activity on this project for a while, so to help other people who want this working, I have released my fork as an NPM named @vlasky/quoted-printable. |
|
awesome thanks man, very helpful |
- Update NAN from 2.14.0 to 2.22.2 (officially supports Node.js 8-22) - All tests pass on Node.js 24.2.0 - Update @ronomon/queue from 3.0.0 to 3.0.1 - Add engines field requiring Node.js >=8.0.0 - Update description and README to reflect Node.js 8+ support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use the latest version of nan (2.14.0). Tweaks were made to the semantics of Uint32Value() to fix compilation errors.