forked from vitejs/vite
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Rolldown with Vite v6 #43
Draft
sapphi-red
wants to merge
100
commits into
main
Choose a base branch
from
rolldown-v6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,397
−2,683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
force-pushed
the
rolldown-v6
branch
10 times, most recently
from
September 18, 2024 09:15
1d231ee
to
2087832
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
September 19, 2024 09:23
259bd2a
to
6af67ee
Compare
FYI,
this is by design, if use customResolver in native plugin, there is no performance difference between |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sapphi-red
force-pushed
the
rolldown-v6
branch
from
September 25, 2024 03:30
066d276
to
04c717f
Compare
Closed
sapphi-red
force-pushed
the
rolldown-v6
branch
3 times, most recently
from
October 10, 2024 02:13
2f09b9c
to
66201d6
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
October 15, 2024 07:05
db6e5bd
to
504ad37
Compare
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
* feat: use oxc for lowering * chore: skip modulepreload polyfill test for now
* feat: use transformWithOxc for extractExportsData * feat: make esbuild optional peer dep * chore: fix types
sapphi-red
force-pushed
the
rolldown-v6
branch
from
December 26, 2024 03:15
485512c
to
53d03ed
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
December 26, 2024 04:27
ff51646
to
a839caa
Compare
it's now a dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied changes from #24 and #27 to the main branch after the environment API PR is merged.
Also fixed errors on Windows and cleaned up some unneeded changes.
#24 implemented build-time dep optimization partially, but I didn't include that change in this PR.
e2e test status
useDefineForClassFields: false
is not supported by oxc (rolldown/rolldown#2296, oxc-project/oxc#6735)missing feature list that was supported by esbuild / rollup
options.watch
watcher.on('event', listener)
shouldTransformCachedModule
,watchChange
,closeWatcher
this.addWatchFile
meta
on module info: this can be workarounded as it's not part of the public APIsystem
formatoutput
is currently an object instead of an arrayoptions.attributes
forresolveId
hookresolveImportMeta
hook: can usetransform
hook for Vite's usecaseoptions.preserveEntrySignatures
: not necessary but nice for smaller bundlesoxc missing feature list that was supported by esbuild
useDefineForClassFields
(transformer: typescript--useDefineForClassFields
oxc-project/oxc#6735)native plugin incompatibilities
customResolver
optionplayground/backend-integration
, you can see the manifest not containingcss
andassets
field inindex.html
.intended behavior differences
define
does not share reference for objects oxc-project/oxc#7641require
is never transformed intoimport
, users needs to inject a polyfill on their own, see f4c3629TODO list for me
bundle
: https://github.com/vuejs/vitepress/blob/68150a6f3349c1741ed5683e3010d9ecea02f3a8/src/node/plugin.ts#L353-L362esbuild.tsconfigRaw
/esbuild.tsconfig
tooxc