Skip to content

adding log capability to client#115

Merged
pawelsz-rb merged 5 commits intomasterfrom
pawel/move_log_to_client
Jun 5, 2025
Merged

adding log capability to client#115
pawelsz-rb merged 5 commits intomasterfrom
pawel/move_log_to_client

Conversation

@pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Jun 1, 2025

Description of the change

Making logging capability on the client .

Now sending messages works on both package (rollbar) and client levels.
example:

import "github.com/rollbar/rollbar-go"

rb_client := rollbar.New(...)
// stuff happens
rb_client.Log("error", err, request, ...)
// or 
rb_client.Error(err, request, ...)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb pawelsz-rb requested a review from brianr June 1, 2025 07:20
Copy link

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a few very minor comments.

Copy link

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @pawelsz-rb!

@pawelsz-rb pawelsz-rb merged commit 4c2ee8c into master Jun 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Log a method of Client

2 participants