Skip to content

Export SetContext to support mocking Transport#113

Merged
pawelsz-rb merged 1 commit intomasterfrom
pawel/make_setContext_public
Mar 10, 2025
Merged

Export SetContext to support mocking Transport#113
pawelsz-rb merged 1 commit intomasterfrom
pawel/make_setContext_public

Conversation

@pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Mar 10, 2025

Description of the change

Export the setContext method of the Transport interface to allow mocking via reimplmentation.

This build includes automatic and indirect reference of new package of rollbar-go/errors in the go.mod and go.sum files

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally (I was unable to determine what lint rules this might be referencing)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb pawelsz-rb merged commit dbf974f into master Mar 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexported function on the Transport interface prevents mocking

2 participants