-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for workspace projects #67
base: master
Are you sure you want to change the base?
Add support for workspace projects #67
Conversation
1c55545
to
ac6d7dc
Compare
One of the unit tests is failing in the CI, so can you take a look at that? Also, does this change need to account for aliases (when we install some package with a different name)? |
I think I got caught by mac's case-insensitive file system 🤦 The name comparison here doesn't touch the dependencies, it's only comparing the "host" package name to make sure it is used as the root dependency in the graph, so those aliases shouldn't apply |
Looks like it's still failing. |
fd46d32
to
5898388
Compare
oh wow, I completely forgot about this! I'll try and give it a good review this week. Sorry about that! |
no worries, revisiting. There the problem with CI is the npm version tagged there vs what I was testing against. I need to dig into the differences and find what's causing it. |
- `npm ls` always lists dependencies from the root project, even if running from a workspace project. This changes uses the `--json` and `--long` options in order to only parse dependencies from the current project tree - note: node_modules loctiaon changes significantly between npm versions
5898388
to
741ad53
Compare
workflow passed on my fork, should be good to go |
I'm so sorry this fell through the cracks for so long. Do you mind taking a look at the merge conflicts and letting us know if this is still something that is needed? Also, I'm not entirely familiar with "workspace projects", so do you mind giving a quick overview of that that actually means? Once I have a better understanding of what this solves, I'm happy to merge it and cut a release. |
npm ls
for workspace projects include the "root" project, resulting in ropm including the workspace project as a dependency of itself, and adding postfixes (_v1, etc.) to its actual dependenciesHow:
--json
fornpm ls
instead of--parseable
name
field