add context menu support #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGM3
reviewed
Sep 3, 2019
src/options.html
Outdated
| <div class="panel-body"> | ||
| <input id="contextMenu" type="checkbox" /> <label for="contextMenu">Context menu button</label> | ||
| <br /> | ||
| <small>Can be very usefull if you don't like to use your keyboard often.</small> |
There was a problem hiding this comment.
Thanks, I fixed that.
However, I think there are other more serious errors with my code. I couldn't find time to debug, because it doesn't break the extension, only my context menu. I couldn't find where it is so far...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great job! I love your extension. Although, the code smells a little bit, i.e. you could refactor it with some state management lib in the future (I had hard time tracing your events). Nevertheless, you have my 10 of 10 for the effort.
Today, I've created an option to use the context menu for quick searching, without using the keyboard, only mouse clicks. This's very helpful since I'm reading with my mouse, no keyboard involved. Maybe other will like this option as well.