Fixed the problem. We needed to allocate the array on the heap. Also …

…make sur to free the array and the strings
rogchap · Dec 23, 2021 · d934d91 · d934d91
1 parent 67958de
commit d934d91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/context.go b/context.go
@@ -175,8 +175,10 @@ func valueStrings(ctx *Context, rtn C.RtnStrings) []string {
 	var result []string
 	for i := 0; i < len(slice); i++ {
 		s := slice[i]
+		defer C.free(unsafe.Pointer(s))
 		result = append(result, C.GoString(s))
 	}
+	defer C.free(unsafe.Pointer(rtn.strings))
 	return result
 }
 

diff --git a/v8go.cc b/v8go.cc
@@ -1298,7 +1298,7 @@ RtnStrings ObjectGetPropertyNames(ValuePtr ptr) {
   Local<Array> names = maybe_names.ToLocalChecked();
 
   uint32_t length = names->Length();
-  const char* strings[length];
+  const char **strings = new const char*[length];
 
   for (int i = 0; i < length; i++) {
     Local<Value> name_from_array = names->Get(local_ctx, i).ToLocalChecked();