rename GetPropertyNames to GetEnumerablePropertyNames

rogchap · Jan 11, 2022 · 97bce5a · 97bce5a
1 parent b70d63b
commit 97bce5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/object.go b/object.go
@@ -86,7 +86,7 @@ func (o *Object) SetIdx(idx uint32, val interface{}) error {
 
 // Returns an array containing the names of the enumerable properties of this object,
 // including properties from prototype objects
-func (o *Object) GetPropertyNames() []string {
+func (o *Object) GetEnumerablePropertyNames() []string {
 	rtn := C.ObjectGetPropertyNames(o.ptr)
 	return valueStrings(o.ctx, rtn)
 }

diff --git a/object_test.go b/object_test.go
@@ -191,7 +191,7 @@ func TestObjectDelete(t *testing.T) {
 
 }
 
-func TestObjectGetPropertyNames(t *testing.T) {
+func TestGetEnumerablePropertyNames(t *testing.T) {
 	t.Parallel()
 
 	ctx := v8.NewContext()
@@ -204,7 +204,7 @@ func TestObjectGetPropertyNames(t *testing.T) {
 	obj.Set("hello", "world")
 
 	expectedProperties := []string{"bar2", "foo", "hello"}
-	properties := obj.GetPropertyNames()
+	properties := obj.GetEnumerablePropertyNames()
 
 	if !reflect.DeepEqual(properties, expectedProperties) {
 		t.Error("properteis are not the same")