Rename description field of dependencies and add a default value. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the description field of a dependency is not provided, the description of the project itself was used instead. We avoid this by renaming the former field, and we default to using the opam name when the description is not provided.
|
It would be nice if you didn't need to rename the field, but it should work this way. |
Member
Author
|
Yes, but I don't know how to avoid this. |
Member
Author
|
If we want to finish this, the documentation in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the description field of a dependency is not provided, the description of the project itself was used instead. We avoid this by renaming the former field, and we default to using the opam name when
the description is not provided.
This avoids an issue reported by @gmalecha on Gitter (https://gitter.im/coq-community/Lobby?at=5eb0827b14b48f0698ac6a3d).