Skip to content

feat: Expose AWS endpointOverride option #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Expose AWS endpointOverride option #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cloud/aws/aws_retry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ Status AwsCloudOptions::GetClientConfiguration(
if (cloud_fs_options.request_timeout_ms != 0) {
config->requestTimeoutMs = cloud_fs_options.request_timeout_ms;
}
config->endpointOverride = cloud_env_options.aws_options.endpoint_override;

config->region = ToAwsString(region);
return Status::OK();
Expand Down
10 changes: 10 additions & 0 deletions include/rocksdb/cloud/cloud_file_system.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ using S3ClientFactory = std::function<std::shared_ptr<Aws::S3::S3Client>(
const std::shared_ptr<Aws::Auth::AWSCredentialsProvider>&,
const Aws::Client::ClientConfiguration&)>;

// Additional AWS options
class AwsOptions {
public:
// Override the http endpoint used to talk to a service.
std::string endpoint_override;
};

// Defines parameters required to connect to Kafka
class KafkaLogOptions {
public:
Expand Down Expand Up @@ -209,6 +216,9 @@ class CloudFileSystemOptions {
// Default: null
std::shared_ptr<CloudStorageProvider> storage_provider;

// AWS additional options
AwsOptions aws_options;

// Access credentials
AwsCloudAccessCredentials credentials;

Expand Down