Skip to content

fix(test/mocks): correct three Python truthiness/isinstance traps #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrishaReddygari wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix(test/mocks): correct three Python truthiness/isinstance traps #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24bb8f2
fix(test/mocks): exclude bool from int LIMIT detection in psycopg2 mock
TrishaReddygari May 3, 2026
465da20
fix(test/mocks): treat limit=0 as zero in chromadb mock get()
TrishaReddygari May 3, 2026
8fa4236
fix(test/mocks): preserve 0.0 distance in weaviate mock sort
TrishaReddygari May 3, 2026
2a51dad
fix(test/mocks): move chromadb mock limit check before append
TrishaReddygari May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions nodes/test/mocks/chromadb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@ def get(
if count < offset:
count += 1
continue


# Apply limit (must be checked before append so limit=0 returns zero items)
if limit is not None and len(results["ids"]) >= limit:
break

results["ids"].append(id)
if "metadatas" in include:
results["metadatas"].append(self._serialize_metadata(metadata))
Expand All @@ -197,11 +201,7 @@ def get(
results["embeddings"].append(data.get("embedding"))

count += 1

# Apply limit
if limit and len(results["ids"]) >= limit:
break


return results

def upsert(
Expand Down
4 changes: 2 additions & 2 deletions nodes/test/mocks/psycopg2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def _handle_semantic_search(self, query: str, params: Tuple):
query_vector = p.tolist()
elif isinstance(p, (list, tuple)) and len(p) > 3:
query_vector = list(p)
elif isinstance(p, int) and p < 1000:
elif isinstance(p, int) and not isinstance(p, bool) and p < 1000:
limit = p
else:
filter_params.append(p)
Expand Down Expand Up @@ -305,7 +305,7 @@ def _extract_limit(self, query: str, params: Tuple) -> Optional[int]:
if "limit" in query.lower() and params:
# Last param is often the limit
for p in reversed(params):
if isinstance(p, int) and p < 10000:
if isinstance(p, int) and not isinstance(p, bool) and p < 10000:
return p
return None

Expand Down
2 changes: 1 addition & 1 deletion nodes/test/mocks/weaviate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def near_vector(
))

# Sort by distance (lower is better for cosine distance)
results.sort(key=lambda x: x.metadata.distance if x.metadata.distance else 1.0)
results.sort(key=lambda x: x.metadata.distance if x.metadata.distance is not None else 1.0)

return QueryResult(objects=results[:limit])

Expand Down
Loading