Skip to content

fix(server): clear _task_control on stop_task to prevent terminate #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsapandora wants to merge 6 commits into from
+7 −1
Closed

fix(server): clear _task_control on stop_task to prevent terminate #733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68a86f5
fix(server): clear _task_control on stop_task to prevent terminate→us…
dsapandora Apr 30, 2026
093decd
fix(server): clear _task_control on stop_task to prevent terminate
dsapandora Apr 30, 2026
0279d0f
fix(server): clear _task_control on stop_task to prevent terminate
dsapandora Apr 30, 2026
4c7798e
ci(test): run builder test sequentially to isolate cross-suite flakes
dsapandora Apr 30, 2026
713458f
Merge branch 'develop' into fix/stop-task-cleanup-race
kwit75 May 1, 2026
66210b2
Merge branch 'develop' into fix/stop-task-cleanup-race
kwit75 May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ai/src/ai/modules/task/task_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,9 @@ async def stop_task(self, token: str):
# Only terminate tasks that were launched or executed directly
if control.launch_type in (LAUNCH_TYPE.LAUNCH, LAUNCH_TYPE.EXECUTE):
await control.task.stop_task()
# Free the slot so a subsequent use() with the same token
# does not race against a phantom registry entry.
self._task_control.pop(token, None)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
self.debug_message(f'Task "{control.id}" stopped on request')

except Exception as e:
Expand Down
46 changes: 25 additions & 21 deletions packages/client-typescript/tests/RocketRideClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,31 +150,35 @@ describe('RocketRideClient Integration Tests', () => {
TEST_CONFIG.timeout
);

it('should get pipeline status', async () => {
const result = await client.use({
pipeline: getEchoPipeline(),
token: PIPELINE_TOKEN,
});
it(
'should get pipeline status',
async () => {
const result = await client.use({
pipeline: getEchoPipeline(),
token: PIPELINE_TOKEN,
});

// Retry a few times in case server is busy (tests may run in parallel)
const maxAttempts = 5;
const delayMs = 2000;
let status: Awaited<ReturnType<typeof client.getTaskStatus>> | null = null;
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
try {
status = await client.getTaskStatus(result.token);
break;
} catch (e) {
if (attempt === maxAttempts) throw e;
await new Promise((r) => setTimeout(r, delayMs));
// Retry a few times in case server is busy (tests may run in parallel)
const maxAttempts = 5;
const delayMs = 2000;
let status: Awaited<ReturnType<typeof client.getTaskStatus>> | null = null;
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
try {
status = await client.getTaskStatus(result.token);
break;
} catch (e) {
if (attempt === maxAttempts) throw e;
await new Promise((r) => setTimeout(r, delayMs));
}
}
}

expect(status).toHaveProperty('state');
expect(Object.values(TASK_STATE)).toContain(status!.state);
expect(status).toHaveProperty('state');
expect(Object.values(TASK_STATE)).toContain(status!.state);

await client.terminate(result.token);
}, 90000);
await client.terminate(result.token);
},
TEST_CONFIG.timeout
);

it(
'should terminate a pipeline',
Expand Down
Loading