fix: retry transient pipe open failures after use(filepath)#711
Draft
Leela8256 wants to merge 1 commit intorocketride-org:developfrom
Draft
fix: retry transient pipe open failures after use(filepath)#711Leela8256 wants to merge 1 commit intorocketride-org:developfrom
Leela8256 wants to merge 1 commit intorocketride-org:developfrom
Conversation
Handle short data-port startup races in Python SDK send() by retrying transient connection-refused errors in DataPipe.open, and add a regression test that validates the documented use(filepath)->send flow. Made-with: Cursor
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle transient startup races in the Python SDK by retrying
DataPipe.open()on short-lived connection-refused errors afteruse(filepath=...), and add a regression test for the documenteduse(filepath) -> send(...)flow.Summary
DataPipe.open()for transient connection-refused errors during task data-port warm-upuse(filepath=...)followed bysend(...)(Issueclient.send()doesn't trigger the engine and throws an error #460 docs flow)Affected Files
packages/client-python/src/rocketride/mixins/data.pypackages/client-python/tests/RocketRideClient_test.pyType
fix
Testing
./builder testpassesChecklist
Linked Issue
Fixes #460
co-author: cursor