Skip to content

fix(clients): pipe errors (Python + TS), SSE rollback, getTaskStatus timeout #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsapandora merged 17 commits into from
May 14, 2026
Merged

fix(clients): pipe errors (Python + TS), SSE rollback, getTaskStatus timeout #704

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ce0cd6d
fix(python-client): improve send() pipe error context
Apr 25, 2026
47b825f
docs(python-client): document PipeException for pipe ops
Apr 25, 2026
d82aec4
fix(python-client): make PipeException catchable as RuntimeError
Apr 26, 2026
79fb921
docs(python-client): note PipeException RuntimeError compatibility
Apr 26, 2026
39e6865
fix(ts-client): improve data pipe error context
Apr 28, 2026
949a595
fix(ts-client): wrap SSE setEvents errors
Apr 28, 2026
64a9451
merge develop into fix/python-send-error-context
Apr 29, 2026
7cff80e
ci: default ROCKETRIDE_APIKEY for fork PRs
Apr 29, 2026
a6671f6
fix(ts-client): timeout getTaskStatus for CI stability
Apr 30, 2026
495dba5
Revert "ci: default ROCKETRIDE_APIKEY for fork PRs"
Apr 30, 2026
63fea26
test: pass default ROCKETRIDE_APIKEY to local test server
Apr 30, 2026
b120203
fix(ts-client): ignore blank ROCKETRIDE_APIKEY env
Apr 30, 2026
6ba2b13
test(py-client): default ROCKETRIDE_APIKEY for pytest env
Apr 30, 2026
13ac8f1
fix(ts-client): avoid half-open pipe on SSE failure; task status timeout
May 4, 2026
98b4ae1
merge develop into fix/python-send-error-context
May 4, 2026
b5e83a8
style(py-client): ruff-format data.py
May 4, 2026
4bf6fc3
Merge remote-tracking branch 'origin/develop' into fix/python-send-er…
dsapandora May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions packages/client-python/src/rocketride/mixins/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
import mimetypes
from pathlib import Path
from typing import Dict, Any, List, Union, Tuple, Optional
from ..core import DAPClient
from ..core import DAPClient, PipeException
from ..types import PIPELINE_RESULT, UPLOAD_RESULT


Expand Down Expand Up @@ -174,7 +174,17 @@ async def open(self) -> 'DataMixin.DataPipe':
response = await self._client.request(request)

if self._client.did_fail(response):
raise RuntimeError(response.get('message', 'Your pipeline is not currently running.'))
msg = response.get('message') or 'Failed to open a data pipe.'
msg = (
f"{msg}\n\n"
"Common causes:\n"
"- Pipeline isn't running (wrong token or task terminated)\n"
"- Pipeline source is `chat` (use `client.chat()`), not `webhook`/`dropper`\n"
"- MIME type doesn't match the source lane (try `mimetype=\"text/plain\"`)\n"
)
response = dict(response)
response['message'] = msg
raise PipeException(response)
Comment thread
stepmikhaylov marked this conversation as resolved.
Comment thread
stepmikhaylov marked this conversation as resolved.

self._pipe_id = response.get('body', {}).get('pipe_id')
self._opened = True
Expand Down Expand Up @@ -224,7 +234,10 @@ async def write(self, buffer: bytes) -> None:
response = await self._client.request(request)

if self._client.did_fail(response):
raise RuntimeError(response.get('message', 'Failed to write to pipe'))
msg = response.get('message') or 'Failed to write to a data pipe.'
response = dict(response)
response['message'] = msg
raise PipeException(response)
Comment thread
coderabbitai[bot] marked this conversation as resolved.

async def close(self) -> PIPELINE_RESULT:
"""
Expand Down Expand Up @@ -259,7 +272,10 @@ async def close(self) -> PIPELINE_RESULT:
response = await self._client.request(request)

if self._client.did_fail(response):
raise RuntimeError(response.get('message', 'Failed to close pipe'))
msg = response.get('message') or 'Failed to close a data pipe.'
response = dict(response)
response['message'] = msg
raise PipeException(response)

return response.get('body', {})

Expand Down
Loading