Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zero): Pin valita to 0.3.11. #3162

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore(zero): Pin valita to 0.3.11. #3162

merged 1 commit into from
Dec 2, 2024

Conversation

aboodman
Copy link
Contributor

@aboodman aboodman commented Dec 2, 2024

There is a breaking change in 0.3.15. The func() method on OptionalType has been removed.

There is a breaking change in 0.3.15. The func() method on
OptionalType has been removed.
@aboodman aboodman requested a review from arv December 2, 2024 02:31
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replicache-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 2:33am
zbugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 2:33am

@aboodman aboodman enabled auto-merge (rebase) December 2, 2024 02:31
@aboodman
Copy link
Contributor Author

aboodman commented Dec 2, 2024

Upgrading to ^0.3.15 would be better but I tried that and the worker tests broke for some reason I couldn't understand.

@arv
Copy link
Contributor

arv commented Dec 2, 2024

Let me see if I can upgrade it. They added some performance improvements in the last release

@arv
Copy link
Contributor

arv commented Dec 2, 2024

I'll also file an issue so that they can be aware of these breaking changes and maybe start paying more attention to them in the future.

@arv
Copy link
Contributor

arv commented Dec 3, 2024

I had some conversations with @jviide

badrap/valita#69
badrap/valita#73

I think we can move to 0.4.x but it does need some work which we at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants