Conversation
jaredramirez
force-pushed
the
add-num-atan-builtin
branch
from
73e066f to
221cae2
Compare
rtfeldman
reviewed
Sep 26, 2020
jaredramirez
force-pushed
the
add-num-atan-builtin
branch
4 times, most recently
from
c6394f3 to
1621a12
Compare
jaredramirez
force-pushed
the
add-num-atan-builtin
branch
2 times, most recently
from
74fb3e7 to
bc1b669
Compare
jaredramirez
force-pushed
the
add-num-atan-builtin
branch
from
bc1b669 to
5cafbcd
Compare
Collaborator
Author
|
This PR is ready to go! Sorry for all the force pushes, had some issue with CI failing and didn't want to keep all of the in-progress commits 😀 |
Contributor
|
PR looks good! Tests pass on my machine, and it appears the CI failure is due to a bug involving I'm looking into that. |
rtfeldman
approved these changes
Sep 27, 2020
Contributor
rtfeldman
left a comment
rtfeldman
left a comment
There was a problem hiding this comment.
Looks like it just needed to have its .bc file regenerated - I'll add a script to make that easier, and a check for CI so we can tell if it needs to be regenerated.
Thanks @jaredramirez! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #532