Merge branch 'master' into add_grafana_loki_tool

README.md

@@ -19,6 +19,7 @@ To this 👇
 
 ### Key Features
 - **Automatic data collection:** HolmesGPT surfaces up the observability data you need to investigate
+- **Secure:** *Read-only* access to your data - respects RBAC permissions 
 - **Runbook automation and knowledge sharing:** Tell Holmes how you investigate today and it will automate it
 - **Extensible:** Add your own data sources (tools) and Holmes will use them to investigate
 - **Data Privacy:** Bring your own API key for any AI provider (OpenAI, Azure, AWS Bedrock, etc)

helm/holmes/templates/holmes.yaml

@@ -24,6 +24,9 @@ spec:
       imagePullSecrets:
       {{- toYaml .Values.imagePullSecrets | nindent 6 }}
       {{- end }}
+      {{- if .Values.affinity }}
+      affinity: {{ toYaml .Values.affinity | nindent 8 }}
+      {{- end }}
       containers:
       - name: holmes
         image: "{{ .Values.registry }}/{{ .Values.image }}"

helm/holmes/values.yaml

@@ -20,6 +20,8 @@ enablePostProcessing: false
 postProcessingPrompt: "builtin://generic_post_processing.jinja2"
 openshift: false
 
+affinity: {}
+
 tolerations: []
 
 serviceAccount:

holmes/plugins/toolsets/kubernetes.yaml

@@ -125,7 +125,12 @@ toolsets:
               }
               print namespace, name, sum_memory(requests) " Mi";
             }' | sort -k3 -nr
-
+      
+      - name: "kubernetes_jq_query"
+        description: > 
+          Use kubectl to get json for all resources of a specific kind pipe the results to jq to filter them. Do not worry about escaping the jq_expr it will be done by the system on an unescaped expression that you give. e.g. give an expression like .items[] | .spec.containers[].image | select(test("^gcr.io/") | not)
+        command: kubectl get {{ kind }} --all-namespaces -o json | jq -r {{ jq_expr }}
+
 
     # NOTE: this is only possible for probes with a healthz endpoint - we do this to avoid giving the LLM generic
     # http GET capabilities which are more powerful than we want to expose

tests/llm/README.md

@@ -55,7 +55,7 @@ Here are the possible fields in the `test_case.yaml` yaml file:
 Run the following:
 
 ```sh
-UPLOAD_DATASET=1 RUN_LIVE=1 pytest ./tests/llm/test_ask_holmes.py -k 999_my_test_case
+UPLOAD_DATASET=1 RUN_LIVE=1 poetry run pytest ./tests/llm/test_ask_holmes.py -k 999_my_test_case
 ```
 
 The test may pass or not based on whether the evaluation scores are high enough. If the test fail,