Try to integrate a CI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palainp
reviewed
Jun 4, 2024
.github/workflows/docker.yml
Outdated
|
|
||
| - run: ./build-with.sh docker | ||
|
|
||
| - run: sh -exc 'if [ $(sha256sum dist/qubes-firewall.xen | cut -d " " -f 1) = $(grep "SHA2 last known" build-with.sh | rev | cut -d ":" -f 1 | rev | cut -d "\"" -f 1 | tr -d " ") ]; then echo "SHA256 MATCHES"; else exit 42; fi' |
There was a problem hiding this comment.
I'm unhappy with those shell commands to compare the result hashsum with qubes-mirage-firewall. It's too sensitive to the string format. Maybe it can be better to have a dedicated file containing the result of the sha256sum command in the repository?
This will also avoid to change the name of the .xen file.
build-with.sh
Outdated
| echo Building MirageVPN... | ||
| $builder run --rm -i -v `pwd`:/tmp/orb-build:Z qubes-miragevpn | ||
| echo "SHA2 of build: $(sha256sum ./dist/qubes-firewall.xen)" | ||
| echo "SHA2 last known: 0cbb202c1b93e10ad115c9e988f9384005656c0855ec9deaf05a5e9ac9972984" |
There was a problem hiding this comment.
With a dedicated file, this will need to be changed for a cat command :)
…e a specific branch for them to build the unikernel
Update the CI system
|
I re-opened this PR, and indeed it now contains the code from #2, but nothing is in the main branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.