Expose write failures in flush #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can keep authors of commits (@dpatti and @dhouse-js - a |
ada2k
force-pushed
the
expose-write-failures-in-flush
branch
from
ea6ed49 to
b325ffe
Compare
Completes merge of inhabitedtype/httpaf#217 Co-authored-by: David House <[email protected]> Co-authored-by: Doug Patti <[email protected]>
ada2k
force-pushed
the
expose-write-failures-in-flush
branch
from
b325ffe to
2d95e23
Compare
|
All done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inhabitedtype/httpaf#217 and https://github.com/ada2k/httpaf/tree/expose-write-failures-in-flush
I've changed this to add back in
flush: t -> (unit -> unit) -> unitfor old code and code that only expects to flush once and so doesn't care about the result.The original PR changes write_ functions to be guarded behind an if statement, and do nothing instead of raising if the user tries to write to a closed Faraday.t so that this can be properly handled in
flush_with_reason. I've removed tests that expect for it to raise.Sidenote: I also have a patch which integrates httpun-types for greater interop between both ocaml-h2 and httpun. LMK if this would be appreciated by h1 :)