-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csrf tokens #65
Merged
Csrf tokens #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could you rebase on top of the main branch, so the CI failure should go? :) |
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
hannesm
reviewed
Oct 15, 2024
Lots of nice additions and refactorings. I'm still wondering (and that may be because your initial PR comment needs to be updated):
I guess we need to tackle some other issues (n upcoming refactorings):
|
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
(rebased and force-pushed on main) |
rename cookie_value_from_cookie to cookie_value
IMHO ready to go now |
Thank you @hannesm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40
This PR adds functionality for CSRF token.
When a user is authenticated, we use a Double Synchronizer Pattern which keeps the token on the server and transmit a copy as hidden field to the form.
When a user is not authenticated, we use a Naive Double Submit Cookie Pattern which sends the token in a cookie and also a hidden field on the form.
We also add a custom header
X-MOLLY-CSRF
. Will experiment with this to see if it's better for unauthenticated users than cookies.