Added relay example. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
requested changes
Dec 2, 2023
There was a problem hiding this comment.
Mostly looks good, thanks! Just a few comment related adjustments, see https://github.com/robotpy/examples/blob/main/CONTRIBUTING.md#include-all-the-comments and the rest of that doc.
Thanks!
relay/robot.py
Outdated
| self.relayReverseButton = 2 | ||
|
|
||
| def teleopPeriodic(self): | ||
| """ |
There was a problem hiding this comment.
This comment isn't present in the original example, so let's omit it.
|
Tried to fix the comments. Thanks for the quick feedback. |
auscompgeek
reviewed
Dec 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added code to another person's repository before, so I am trying to start small. I saw the request for more examples and tried to pick the easiest thing I could. Probably not a super helpful example, but if I can do this well, I will try to pick off more important stuff later.