Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sysId example #111

Merged
merged 17 commits into from
Mar 10, 2024
Merged

add sysId example #111

merged 17 commits into from
Mar 10, 2024

Conversation

LucienMorey
Copy link
Contributor

@LucienMorey LucienMorey commented Jan 18, 2024

Currently a WIP...

Outstanding tasks:

  • Finish Port of robot.py
  • confirm sysid log function is correct
  • convert docs strings
  • run on robot

@LucienMorey LucienMorey marked this pull request as draft January 18, 2024 12:48
@LucienMorey
Copy link
Contributor Author

I don't have a tank drive handy to test this properly but I did adapt it for my team's swerve drive and deploy it there. feel free to request changes but I think this is good to go as a baseline

@LucienMorey LucienMorey marked this pull request as ready for review January 21, 2024 04:23
@auscompgeek
Copy link
Member

Please add the robot to the test list.

SysId/sysidroutinebot.py Outdated Show resolved Hide resolved
SysId/subsystems/drive.py Outdated Show resolved Hide resolved
@LucienMorey LucienMorey requested a review from auscompgeek March 10, 2024 03:31
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@auscompgeek auscompgeek merged commit 4ca730a into robotpy:main Mar 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants