Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Command Code plugin #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: add Command Code plugin #441
Changes from 9 commits
c49cbdf68d10494ec0ea9a272882205f5c0eeaf6da1f0b118fc2b2e6e38a47c74d18aaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
planIdis not inPLAN_LIMITS,totalbecomes0, theif (planId && total > 0)block is skipped, and the plugin returnslines: []; runtime then converts that into an error line ("no lines returned"insrc-tauri/src/plugin_engine/runtime.rs), so users on any new/renamed Command Code plan get a false failure despite successful API responses. Return at least one fallback line (or explicit unsupported-plan error) instead of an empty array.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
planIdis not present inPLAN_LIMITS,totalbecomes0and this guard skips all output lines, soprobe()returnslines: []. In the current runtime, empty lines are converted to an error line ("no lines returned"insrc-tauri/src/plugin_engine/runtime.rs), which makes the plugin show an error for valid accounts on newly introduced/unknown plans. This means plan catalog changes on Command Code can silently break usage display until a code update.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AGENTS.md(repo root) saysplugin.jsonmust use the provider’s realbrandColor, but this value is set to neutral gray#575757rather than Command Code’s published brand palette colors, so the provider is misbranded in UI and violates the project’s plugin requirement.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.