Clean up outdated comments in BPE tokenizer, pass configuration as a struct #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove GPT-2 regex constant. This has been moved to the `pre_tokenizers` module. - Remove references to regex splitting in `Bpe::new` docs
Make `Bpe::new` take configuration as a struct rather than separate args. This will make it easier to extend and also allows to consumers to use the `Default` impl to fill out unused args. Also export the `EncodedByteSlice` and `EncodedBytes` types so they show up in the docs. Otherwise these types show up as the original type (&str, String) rather than the alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #453, do a pass over the BPE tokenizer to clean up outdated documentation and make passing configuration to
Bpe::newmore readable / easier to extend by using an options struct.