Extract pre-tokenization out of tokenization models #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for getting the offsets of subslices yielded by pre-tokenization of the normalized input.
Move the regex splitting pre-tokenization out of the BPE model and into a separate pipeline step called by `Tokenizer` after normalization. This makes this pre-tokenization method usable with other tokenization models and is part of aligning the tokenization pipeline in rten-text with Hugging Face Tokenizers.
Align with the naming convention in the tokenizers crate.
robertknight
force-pushed
the
byte-level-pre-tokenizer
branch
from
a69e7dc to
d49d6b2
Compare
This is now subsumed by `TokenizerError::PreTokenizeFailed`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #427, extract the input splitting logic out of the
WordPieceandBpetokenization models and make it a separate pre-tokenization step in the pipeline executed byTokenizer.TODO:
pre_tokenizervspretokenizerin namingpretokenizerfield fromtokenizer.jsonfiles, for already-supported pre-tokenizers