Dorny failure #69
Dorny failure #69
Conversation
…e symbolic links are resolved on MacOS. This fixes test failures on MacOS
Add debugging of TRX files
publish each trx file separately so we know why one fails.
Removed first added debug section
Detailed TRX scan
use JUnit instead of trx for test results.
fixed --format to --output-format
convert trx to junit output before publishing using dorny
Remove dorny-failure branch from push trigger
removed debug step
changed name of WF to simply CI again
Removed dorny-failure from push branches
removed empty line
removed extraneous space character to reduce diffs
| cycodt run --log ./TestResults/test-results-cycodt.log --output-file ./TestResults/test-results-cycodt.xml --output-format junit | ||
| - name: Clean up inception test TRX files | ||
| - name: Clean up inception test result files |
There was a problem hiding this comment.
why not include this in previous step, as its related to previous step?
| rm -f tests/cycodt-yaml/inception-layer-1/*.trx || true | ||
| echo "Cleaned up inception test legacy TRX files" | ||
| - name: Convert TRX to JUnit XML |
There was a problem hiding this comment.
This isn't required for cycodt yaml tests, yes? as we're outputing in junit directly, correct? if so, then, i'd suspect we don't need this for the TRX from dotnet test, as that doesn't seem to be the one that was having difficulty uploading, right? i'm unsure, but I'd like to check first... it's a bit non-standard to have .net tests uploaded in junit format... and, if we want that, we can probably just ask dotnet test to output in that format... and not have this step of the process....
| echo "Cleaned up inception test legacy TRX files" | ||
| - name: Convert TRX to JUnit XML | ||
| if: always() |
There was a problem hiding this comment.
doesn't always condition mean it'll actually run even if the build fails? which, wouldn't be required? why mark as always?
| - name: Upload test results | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() # Upload test results even if tests fail | ||
| if: always() |
| - name: Publish JUnit results | ||
| uses: dorny/[email protected] | ||
| if: always() # Run this step even if previous steps failed | ||
| if: always() |
| src/cycod/bin/Release/net9.0/linux-x64/publish/ | ||
| src/cycod/bin/Release/net9.0/osx-x64/publish/ | ||
| - name: Publish .NET TRX results |
There was a problem hiding this comment.
and then, we also publish the .net TRX results for the dotnet test based tests? i'm a bit confused then, why we need to convert any TRX files to junit xml above...
robch
left a comment
robch
left a comment
There was a problem hiding this comment.
See comments inline... Also, don't we need to do similar for the other pipeline? the publish one? there are two pipelines (action workflows)... one for CI and one for Releasing bits... same folder, different file.
Also fixed directory path with symlink issue for MacOS to fix test failures on MacOS.